Do not call on_success if response contains no data

Tribler · Mar 24, 2023 · a9cb07c · a9cb07c
1 parent 654f139
commit a9cb07c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/tribler/gui/network/request.py b/src/tribler/gui/network/request.py
@@ -104,7 +104,7 @@ def on_finished(self):
  return
 
  if not data:
- self.on_finished_signal.emit({})
+ self.logger.error(f'No data received in the reply for {self}')
  return
 
  self.logger.debug('Create a json response')

diff --git a/src/tribler/gui/network/tests/test_request.py b/src/tribler/gui/network/tests/test_request.py
@@ -40,12 +40,12 @@ def test_str_data_constructor():
 
 def test_on_finished():
  # Test that if 'request.reply' is empty, the `on_finish` method is called with an empty dict.
- # see: https://github.com/Tribler/tribler/issues/7297
+ # see: https://github.com/Tribler/tribler/issues/7333
  on_success = MagicMock()
  request = Request(endpoint='endpoint', on_success=on_success)
  request.manager = MagicMock()
  request.reply = MagicMock(readAll=MagicMock(return_value=b''))
 
  request.on_finished()
 
- on_success.assert_called_once_with({})
+ on_success.assert_not_called()