Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_tribler_main job failing because of GUI imports in the core #6514

Closed
devos50 opened this issue Oct 29, 2021 · 0 comments
Closed

test_tribler_main job failing because of GUI imports in the core #6514

devos50 opened this issue Oct 29, 2021 · 0 comments

Comments

@devos50
Copy link
Contributor

devos50 commented Oct 29, 2021

Our test_tribler_main job is failing because of a GUI import in the core, e.g., see here. This job is linked to a badge that we show on our project homepage.

==================================== ERRORS ====================================
_ ERROR collecting src/tribler-core/tribler_core/components/metadata_store/restapi/tests/test_search_endpoint.py _
ImportError while importing test module '/home/jenkins/workspace/Test_tribler_main/tribler/src/tribler-core/tribler_core/components/metadata_store/restapi/tests/test_search_endpoint.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
src/tribler-core/tribler_core/components/metadata_store/restapi/tests/test_search_endpoint.py:11: in <module>
    from tribler_gui.utilities import to_fts_query
E   ModuleNotFoundError: No module named 'tribler_gui'

We should consider moving the to_fts_query function to the tribler_common package.

@devos50 devos50 added this to the Backlog milestone Oct 29, 2021
@devos50 devos50 changed the title test_tribler_main failing because of GUI imports in the core test_tribler_main job failing because of GUI imports in the core Oct 29, 2021
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Nov 1, 2021
kozlovsky added a commit to kozlovsky/tribler that referenced this issue Nov 1, 2021
kozlovsky added a commit that referenced this issue Nov 1, 2021
Fixes #6514: Move to_fts_query function from tribler_gui.utilities to tribler_common.utilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants