Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lz4 does not compress well enough. #6711

Closed
kotenok2000 opened this issue Jan 7, 2022 · 1 comment · Fixed by #7726
Closed

Lz4 does not compress well enough. #6711

kotenok2000 opened this issue Jan 7, 2022 · 1 comment · Fixed by #7726

Comments

@kotenok2000
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Populate channels folder with data (subscribe to channels)
  2. navigate to channels folder via cmd
  3. Run compact /c /s /a /i /exe:lzx
  4. See that it was able to compress files 1,3 to 1 that have already were compressed with lz4

Expected behavior
Files are not able to be compressed further
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 11
  • Tribler's version: 7.11.0

Additional context
Add any other context about the problem here.

@ichorid
Copy link
Contributor

ichorid commented Jan 7, 2022

We're using LZ4 streaming compression feature to fit data into UDP packets and file-based chunks. Streaming mode is less efficient, but it allows us to avoid backtracking (e.g. when adding the last entry will overflow the chunk size). That said, fitting the chunks tightly is not a priority when dumping them to disk. However, using the same code for both network and torrent-based transfers is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants