GigaChannel removal #7726
Merged
GigaChannel removal #7726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
rebase_giga_cleanup
branch
6 times, most recently
from
a4800ef
to
8666467
Compare
qstokkink
force-pushed
the
rebase_giga_cleanup
branch
3 times, most recently
from
98cffd0
to
bd06c13
Compare
qstokkink
changed the title
qstokkink
force-pushed
the
rebase_giga_cleanup
branch
3 times, most recently
from
c8983cb
to
f5b5d5a
Compare
qstokkink
force-pushed
the
rebase_giga_cleanup
branch
5 times, most recently
from
5e7ccb8
to
140ad13
Compare
qstokkink
force-pushed
the
rebase_giga_cleanup
branch
from
140ad13
to
e5a9e01
Compare
|
@kozlovsky Could you take a look at the changes in:
This works with the new database format but I'm not entirely confident in my implementation. Is there a better way to do this? |
qstokkink
requested review from
a team and
egbertbouman
and removed request for
a team
qstokkink
changed the title
egbertbouman
approved these changes
Nov 30, 2023
qstokkink
changed the title
|
|
Merged
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7669
This PR voids many of the previous issues related to channels.
Fixes #1368
Fixes #2284
Fixes #3615
Fixes #4637
Fixes #4645
Fixes #4650
Fixes #4672
Fixes #4677
Fixes #5015
Fixes #5067
Fixes #5154
Fixes #5271
Fixes #5522
Fixes #5587
Fixes #6208
Fixes #6126
Fixes #6217
Fixes #6395
Fixes #6481
Fixes #6680
Fixes #6711
Fixes #7489
Fixes #7491
The diff is so big that Codacy is broken. However, just before it died, it seemed like all issues were resolved.
The script test is broken because I removed the channel creation script test. I modified the workflow file but this will only take effect in PRs after this PR.
Almost all of the hard work is to be attributed to @egbertbouman. I came in afterward to rebase onto the latest main and tidy up some loose ends.
@egbertbouman is our "lucky" winner on the 25% reviewer assignment chance 🎉 but I would still like an additional review on #7726 (comment) because I feel these three source files could be better.