[7.14] ValueError: missing or invalid info section in torrent file (in ChannelsEndpoint.add_torrent_to_channel)

[kozlovsky]

RuntimeError: missing or invalid 'info' section in torrent file
  File "src\<relief>\core\components\libtorrent\torrentdef.py", line 64, in __init__
ValueError: missing or invalid 'info' section in torrent file
  File "src\<relief>\core\components\restapi\rest\rest_manager.py", line 53, in error_middleware
  File "C:\Users\<relief>\AppData\Local\Programs\Python\Python38\lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
  File "src\<relief>\core\components\metadata_store\restapi\channels_endpoint.py", line 440, in add_torrent_to_channel
  File "src\<relief>\core\components\libtorrent\torrentdef.py", line 117, in load_from_memory
  File "src\<relief>\core\components\libtorrent\torrentdef.py", line 125, in load_from_dict
  File "src\<relief>\core\components\libtorrent\torrentdef.py", line 66, in __init__

Here:

    async def add_torrent_to_channel(self, request):
        ...

        if not parameters.get('torrent', None):
            return RESTResponse({"error": "torrent parameter missing"}, status=HTTP_BAD_REQUEST)

        # Try to parse the torrent data
        # Any errors will be handled by the error_middleware
        torrent = base64.b64decode(parameters['torrent'])
        torrent_def = TorrentDef.load_from_memory(torrent)  # <-- here

The erroneous torrent metadata was:

{
    b'announce': "b'/announce?pid='"
}

It looks like the endpoint code should handle ValueError and return RESTResponse with an error description.

[sentry-for-tribler]

Sentry issue: TRIBLER-1SD

[drew2a]

Exactly this occurrence should be fixed in:

• GigaChannel removal #7726

However, TorrentDef.load_from_memory is used in two more places.

[drew2a]

The remaining calls to TorrentDef.load_from_memory do not lead to an application crash; therefore, I'm closing the issue.