Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Request: Replace Jenkins checks by CodeClimate or Codacy or Codecov #6847

Closed
drew2a opened this issue Apr 6, 2022 · 5 comments
Closed
Assignees
Milestone

Comments

@drew2a
Copy link
Contributor

drew2a commented Apr 6, 2022

Now we perform static code analyses by running pylint and flake8 on our Linux machine.

Problems:

  • Our Jenkins jobs (pylint and flake8) require maintenance procedures from time to time.
  • Our Jenkins jobs (pylint and flake8) slow down a PR check.
  • Generated reports are not inlined and are hard to use.

These checks could be replaced by https://github.com/marketplace/code-climate with:

CodeClimat is free for open-source projects.

SonarCloud Code Analysis and Diff Coverage also could be replaced by CodeClimate:

@drew2a
Copy link
Contributor Author

drew2a commented Apr 6, 2022

Also, we have installed https://about.codecov.io/ but it seems that we don't use it.

@drew2a
Copy link
Contributor Author

drew2a commented Apr 11, 2022

@drew2a drew2a mentioned this issue Apr 11, 2022
@drew2a
Copy link
Contributor Author

drew2a commented Apr 12, 2022

This was referenced Apr 13, 2022
@drew2a drew2a changed the title Improvement Request: Add CodeClimate checks Improvement Request: Replace Jenkins checks by CodeClimate or Codacy or Codecov Apr 13, 2022
@drew2a
Copy link
Contributor Author

drew2a commented Apr 14, 2022

Code coverage diff example: https://app.codecov.io/gh/Tribler/tribler/compare/6866/changes

@drew2a
Copy link
Contributor Author

drew2a commented Apr 14, 2022

Summary:

  • GitHub Actions are used for:
    • pytest win
    • pytest mac
    • pytest ubuntu
    • documentation build
    • code coverage generation
  • Codacy is used for:
    • Static analyses for each PR
    • Static analyses for the whole codebase (every push on main)
  • Codecov is used for:
    • Highlighting a diff coverage for each PR

@drew2a drew2a closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant