Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code climate #6858

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .codeclimate.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,19 @@
#https://docs.codeclimate.com/docs/advanced-configuration#section-configuration-file-structure-and-content

version: "2"

plugins:
# pep8 uses `tox.ini` as a config file
pep8:
enabled: true
bandit:
enabled: true
sonar-python:
enabled: true
# bandit:
# enabled: true
# sonar-python:
# enabled: true

# markdownlint uses `.mdlrc` as a config file
# markdownlint:
# enabled: true
# shellcheck:
# enabled: true

3 changes: 3 additions & 0 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Coverage

on:
push:
branches:
- main
pull_request:

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/documentation.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Documentation (no publish)
name: Documentation

on:
pull_request:
Expand Down
16 changes: 13 additions & 3 deletions README.rst
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
*******
Tribler
*******

|jenkins_build| |docs| |contributors| |pr_closed| |issues_closed|
|Pytest| |docs| |Maintainability| |Coverage| |contributors| |pr_closed| |issues_closed|

|python_3_8| |python_3_9|

Expand Down Expand Up @@ -201,4 +200,15 @@ We like to hear your feedback and suggestions. To reach out to us, you can join
:target: https://www.python.org/

.. |python_3_9| image:: https://img.shields.io/badge/python-3.9-blue.svg
:target: https://www.python.org/
:target: https://www.python.org/

.. |Pytest| image:: https://github.com/Tribler/tribler/actions/workflows/pytest.yml/badge.svg?branch=main
:target: https://github.com/Tribler

.. |Maintainability| image:: https://api.codeclimate.com/v1/badges/a2f61aa9829ac493f6d3/maintainability
:target: https://codeclimate.com/github/Tribler/tribler/maintainability

.. |Coverage| image:: https://api.codeclimate.com/v1/badges/a2f61aa9829ac493f6d3/test_coverage
:target: https://codeclimate.com/github/Tribler/tribler/test_coverage
:alt: Test Coverage

2 changes: 0 additions & 2 deletions src/tribler/core/components/tag/community/tag_community.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
from binascii import unhexlify

from cryptography.exceptions import InvalidSignature

from ipv8.keyvault.private.libnaclkey import LibNaCLSK
from ipv8.lazy_community import lazy_wrapper
from ipv8.types import Key

from pony.orm import db_session

from tribler.core.components.ipv8.tribler_community import TriblerCommunity
Expand Down
1 change: 0 additions & 1 deletion src/tribler/core/components/tag/community/tag_payload.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

from ipv8.messaging.payload_dataclass import overwrite_dataclass, type_from_format


dataclass = overwrite_dataclass(dataclass)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
from unittest.mock import MagicMock, Mock

from cryptography.exceptions import InvalidSignature

from ipv8.keyvault.private.libnaclkey import LibNaCLSK
from ipv8.test.base import TestBase
from ipv8.test.mocking.ipv8 import MockIPv8

from pony.orm import db_session

from tribler.core.components.tag.community.tag_community import TagCommunity
Expand Down
1 change: 0 additions & 1 deletion src/tribler/core/components/tag/db/tests/test_tag_db.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from unittest.mock import Mock, patch

from ipv8.test.base import TestBase

from pony import orm
from pony.orm import commit, db_session

Expand Down
4 changes: 0 additions & 4 deletions src/tribler/core/components/tag/restapi/tags_endpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,9 @@
from typing import Optional, Set, Tuple

from aiohttp import web

from aiohttp_apispec import docs

from ipv8.REST.schema import schema

from marshmallow.fields import Boolean, List, String

from pony.orm import db_session

from tribler.core.components.restapi.rest.rest_endpoint import HTTP_BAD_REQUEST, RESTEndpoint, RESTResponse
Expand Down
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
from unittest.mock import Mock

import pytest
from aiohttp.web_app import Application

from freezegun import freeze_time

from ipv8.keyvault.crypto import default_eccrypto

from pony.orm import db_session

import pytest

from tribler.core.components.restapi.rest.base_api_test import do_request
from tribler.core.components.tag.community.tag_payload import TagOperation, TagOperationEnum
from tribler.core.components.tag.restapi.tags_endpoint import TagsEndpoint
from tribler.core.conftest import TEST_PERSONAL_KEY
from tribler.core.utilities.unicode import hexlify


# pylint: disable=redefined-outer-name

@pytest.fixture
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
from typing import Optional, Set

from ipv8.taskmanager import TaskManager

from pony.orm import db_session

from tribler.core import notifications
Expand Down
3 changes: 1 addition & 2 deletions src/tribler/core/components/tag/tests/test_tag_component.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,11 @@
from tribler.core.components.tag.tag_component import TagComponent

# pylint: disable=protected-access


@pytest.mark.asyncio
async def test_tag_component(tribler_config):
components = [MetadataStoreComponent(), KeyComponent(), Ipv8Component(), TagComponent()]
async with Session(tribler_config, components).start():
comp = TagComponent.instance()
assert comp.started_event.is_set() and not comp.failed
assert comp.community
print(f'test')
11 changes: 11 additions & 0 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
;https://docs.codeclimate.com/docs/pep8
;The PEP8 project has been renamed to pycodestyle.
;The Code Climate PEP8 engine has not been updated to incorporate that name change.
;
;To make configuration specifications in your setup.cfg file or tox.ini file,
;the Code Climate PEP8 engine requires that you include those changes in:
; * a [pep8] config section
; * instead of [pycodestyle] config section.
[pep8]
;https://pep8.readthedocs.io/en/latest/intro.html#configuration
max-line-length = 120