WIP: Handle dispersy returning Deferreds #2416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdversluis
force-pushed
the
fix-dispersy-deferreds
branch
from
a636791
to
7c4028b
Compare
|
very nice cleaned up history :-) |
|
All commits need to be squashed and sorted by file. Moreover, this PR modifies wx which was wrong to begin with. That combined with more than 1.5 weeks of debugging why the allchannel experiment does not perform well (reading logs for several hours a day) makes your mind go dull. |
lfdversluis
force-pushed
the
fix-dispersy-deferreds
branch
3 times, most recently
from
73fcc15
to
a85117f
Compare
lfdversluis
force-pushed
the
fix-dispersy-deferreds
branch
from
dd88023
to
1af55d9
Compare
|
@lfdversluis do you mean something like this? http://stackoverflow.com/questions/10443627/force-git-submodule-to-always-stay-current |
|
It's solved now, had to update my pointer |
|
retest this please Linux and mac passed, added storm to windows 32 and 64 bit, let's see how that goes! |
|
All tests passed 👍 |
It can now handle deferreds returned by Dispersy et al.
It can now handle deferreds returned by Dispersy et al.
It will now asynchronously send the data as it has to wait for deferreds to resolve.
It will now send the data asynchronously because it has to resolve deferreds returned by Dispersy et al.
It will now end the data asynchronously because it has to resolve deferreds returned by Dispersy et al.
Because this will reraise the exception, causing the program and tests to fail. It has been dealt with so do not propogate it.
It will now end the data asynchronously because it has to resolve deferreds returned by Dispersy et al.
It can now handle Deferreds being returned.
It can now handle deferreds returned by Dispersy et al.
Now using the nose reactor, nose deferred decorator and the test now handles deferreds returned by Tribler et al.
Now using the nose reactor, nose deferred decorator and the test now handles deferreds returned by Tribler et al.
Now using the nose reactor, nose deferred decorator and the test now handles deferreds returned by Tribler et al.
It now uses nose's deferred decorator
Now using the nose reactor, nose deferred decorator and the test now handles deferreds returned by Tribler et al.
Else we would get a reactorAlreadyRunningException
Else we get a reactorAlreadyRunningException
Now using the nose reactor, nose deferred decorator and the test now handles deferreds returned by Tribler et al.
Else we get a reactorAlreadyRunningException
Now using the nose reactor, nose deferred decorator and the test now handles deferreds returned by Tribler et al.
Now using the nose reactor, nose deferred decorator and the test now handles deferreds returned by Tribler et al.
To handle deferred returned by Dispersy
To handle deferreds returned by Dispersy
To handle deferreds returned by Tribler and Dispersy
To handle deferreds of Dispersy and Tribler
To handle deferreds returned by the tunnel community
To handle deferreds returned by Dispersy and Tribler
To handle deferreds returned by Dispersy
To handle deferreds returned by Tribler
To handle deferreds returned by Dispersy and Tribler
To handle the deferred returned by Tribler
To handle deferreds returned by Tribler
So Jenkins will checkout the right branch
lfdversluis
force-pushed
the
fix-dispersy-deferreds
branch
from
596cb4a
to
2c51ea9
Compare
|
And now a few fail 👎 |
And fixed some racy teardowns/setups
8 tasks
|
I will close this issue in favor of IPv8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soon™ Dispersy will return deferreds on many calls. This PR makes sure Tribler can handle those.
The following will happen because of this PR:
The wx GUI will no longer function, I did not push any changes (by accident) to wx, so it will call the functions but completely ignore the deferreds returned.
All tests will run on the nose reactor and uses nose's
deferreddecorator.Some tests had blocking behavior which blocked the reactor thread if they ran on the reactor, I have refactored this to use deferreds, which should be only a good thing.