RestAPI start download endpoint #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, only the starting of the DHT is executed on the thread pool. The check itself is executed on the reactor thread.
brussee
force-pushed
the
start_download_infohash
branch
from
40496b3
to
03d27fc
Compare
brussee
force-pushed
the
start_download_infohash
branch
from
b848e9f
to
5fdcbb1
Compare
|
@lfdversluis Would you review this please? |
| @@ -304,7 +302,11 @@ def network_create_engine_wrapper(self, pstate, initialdlstatus=None, checkpoint | |||
|
|
|||
| self.handle = self.ltmgr.add_torrent(self, atp) | |||
|
|
|||
| if self.handle: | |||
| # DEBUG: | |||
There was a problem hiding this comment.
Don't forget to remove this debug statement if it's stable ;)
There was a problem hiding this comment.
Yes, I would like to invite @ardhipoetra to use this in his PR #2399.
|
@brussee good work 👍 |
|
@devos50 Thanks! You too! |
4 tasks
| @@ -185,20 +200,6 @@ def test_get_share_mode(self): | |||
| self.libtorrent_download_impl.handle.status().share_mode = True | |||
| self.assertTrue(self.libtorrent_download_impl.get_share_mode()) | |||
|
|
|||
| def test_set_share_mode(self): | |||
There was a problem hiding this comment.
are you deleting this test as well as the wrapper function?
There was a problem hiding this comment.
I will put it back, but use at own risk!
|
@whirm Ready. |
brussee
changed the title
whirm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problematic wrapper function is now unused: (a flag is used instead by @devos50)