WIP: Added ability to export chain keys #3267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devos50
reviewed
Dec 2, 2017
TriblerGUI/widgets/settingspage.py
Outdated
| from PyQt5 import QtGui | ||
| from PyQt5.QtWidgets import QWidget, QLabel, QFileDialog | ||
| from PIL.ImageQt import ImageQt | ||
| import qrcode |
There was a problem hiding this comment.
Just an idea, we can make this qrcode import conditional, something like:
try:
import qrcode
has_qr = True
except ImportError:
has_qr = False
And show an error if has_qr is False?
There was a problem hiding this comment.
Yeah, that is probably better, so it causes less dependency errors. Do you have an example how I can call an error widget?
There was a problem hiding this comment.
|
@devos50, I updated the code to test if the module is present and also included an error for when the keys are missing or are still being created |
|
This PR has become obsolete and is replaced by PR #3358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #3239, where it is used to export the keys to an android client
Dependencies used:
python-qrcode