Changed TrustChain so it's a single chain instead of multiple fragmented communities #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devos50
changed the title
devos50
requested review from
qstokkink and
xoriole
and removed request for
qstokkink
devos50
force-pushed
the
one_chain
branch
2 times, most recently
from
12b76bc
to
a2da438
Compare
9 tasks
devos50
force-pushed
the
one_chain
branch
3 times, most recently
from
6eb7e76
to
1aa3178
Compare
qstokkink
reviewed
Apr 9, 2018
.gitmodules
Outdated
| @@ -9,4 +9,4 @@ | |||
| url = https://github.com/spesmilo/electrum | |||
| [submodule "py-ipv8"] | |||
| path = Tribler/pyipv8 | |||
| url = https://github.com/Tribler/py-ipv8.git | |||
| url = https://github.com/devos50/py-ipv8.git | |||
There was a problem hiding this comment.
I know and this will be removed after the review and when the IPv8 PR is merged.
xoriole
previously approved these changes
Apr 9, 2018
devos50
changed the title
devos50
changed the title
devos50
force-pushed
the
one_chain
branch
6 times, most recently
from
55f5cf9
to
d0dcc09
Compare
|
retest this please |
devos50
changed the title
qstokkink
reviewed
Jun 25, 2018
| @@ -40,13 +34,19 @@ | |||
| STATE_START_TORRENT_CHECKER, STATE_START_REMOTE_TORRENT_HANDLER, | |||
| STATE_START_API_ENDPOINTS, STATE_START_WATCH_FOLDER, STATE_START_CREDIT_MINING) | |||
| from Tribler.dispersy.util import blockingCallFromThread, blocking_call_on_reactor_thread | |||
| from Tribler.pyipv8.ipv8.attestation.trustchain.community import TrustChainCommunity | |||
There was a problem hiding this comment.
This should be imported when loading the community.
qstokkink
reviewed
Jun 25, 2018
| if block: | ||
| return succeed(block) | ||
|
|
||
| monitor_lc = LoopingCall(check_has_block) |
There was a problem hiding this comment.
This is not a TaskManager managed task and can leak.
qstokkink
reviewed
Jun 25, 2018
| @@ -271,7 +273,7 @@ def update_torrent(self, peers, handle, download): | |||
| def get_peer_from_address(self, address): | |||
| circuit_peer = None | |||
| for peer in self.get_peers(): | |||
| if peer.address == address: | |||
| if peer.address == address and peer.public_key.key_to_bin().startswith("LibNaCLPK:"): | |||
There was a problem hiding this comment.
You can remove this now, fixed in IPv8.
xoriole
previously approved these changes
Jun 25, 2018
This can lead to a dirty threadpool due to IPv8 messages coming in after the test has ended.
ichorid
previously approved these changes
Jun 25, 2018
| global_time = self.claim_global_time() | ||
| dist = GlobalTimeDistributionPayload(global_time).to_pack_list() | ||
| payload = HalfBlockPairPayload.from_half_blocks(block, linked_block).to_pack_list() | ||
| packet = self._ez_pack(self._prefix, 22, [dist, payload], False) |
There was a problem hiding this comment.
Yeah, this is a convention that I followed from the Dispersy era. I will use some defined constants in a subsequent PR 👍
devos50
force-pushed
the
one_chain
branch
2 times, most recently
from
346326b
to
195ef54
Compare
ichorid
previously approved these changes
Jun 25, 2018
This will be an IPv8 plugin
ichorid
approved these changes
Jun 25, 2018
qstokkink
approved these changes
Jun 25, 2018
xoriole
approved these changes
Jun 25, 2018
devos50
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I refactored the communities that were subclassing the TrustChain overlay. Instead, we have a single ledger now and we create separate overlays and communicate with the TrustChain ledger instead. See the IPv8 pull request for more information.
I also updated the master peers of the market + tunnel community. I promise this will be the last time :). Finally, I fixed a bug during the tests where IPv8 would talk with the real world.
Requires Tribler/py-ipv8#96 to be merged first.
I've written a few experiments to verify that everything works as expected with this PR: