Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various unit test fixes #5423

Merged
merged 6 commits into from
Jul 1, 2020
Merged

Various unit test fixes #5423

merged 6 commits into from
Jul 1, 2020

Conversation

egbertbouman
Copy link
Member

No description provided.

@devos50
Copy link
Contributor

devos50 commented Jun 30, 2020

retest this please

2 similar comments
@devos50
Copy link
Contributor

devos50 commented Jun 30, 2020

retest this please

@devos50
Copy link
Contributor

devos50 commented Jun 30, 2020

retest this please

@egbertbouman egbertbouman marked this pull request as ready for review June 30, 2020 14:59
@devos50
Copy link
Contributor

devos50 commented Jul 1, 2020

The fact that self.session.dlmgr.get_channel_downloads = lambda: [] is not covered might indicate a problem with the test. Does the test actually get past the await?

@egbertbouman
Copy link
Member Author

@devos50 Yes, it does. However, the lambda doesn't always get executed. Probably due to timing.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

devos50
devos50 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@devos50 devos50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked out your branch and executed the test_check_torrent_health test. I can confirm that the lines are indeed covered and the full test completes, so it might be some kind of bug in the XML coverage report (which are quite hacky...)

@egbertbouman egbertbouman merged commit 6acca36 into Tribler:release-7.5 Jul 1, 2020
@egbertbouman egbertbouman deleted the various_fixes branch November 26, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devos50 devos50 devos50 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egbertbouman @devos50