Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Fix display name capitalization #6162

Merged
merged 2 commits into from
Jun 17, 2021
Merged

[macOS] Fix display name capitalization #6162

merged 2 commits into from
Jun 17, 2021

Conversation

da2x
Copy link
Contributor

@da2x da2x commented Jun 13, 2021 •
edited
Loading

  • Change app bundle name to “Tribler.app”.
  • Set CFBundleName and CFBundleDisplayName to “Tribler”.

The changes ensures the app is displayed as “Tribler” rather than “tribler” throughout macOS.

@da2x
[macOS] Fix display name capitalization
03e86aa 
Change app bundle name to “Tribler.app”.
Set CFBundleName and CFBundleDisplayName to “Tribler”.
@tribler-ci
Copy link
Contributor

Can one of the admins verify this patch?

@qstokkink
Copy link
Contributor

ok to test

devos50
devos50 approved these changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@devos50 devos50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ichorid ichorid merged commit 74fe625 into Tribler:main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devos50 devos50 devos50 approved these changes

@xoriole xoriole xoriole approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@da2x @tribler-ci @qstokkink @xoriole @devos50 @ichorid