Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6250, fixes #6251: each community should use a separate bootstrapper #6252

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Fixes #6250, fixes #6251: each community should use a separate bootstrapper #6252

merged 1 commit into from
Aug 13, 2021

Conversation

kozlovsky
Copy link
Contributor

Fixes #6250 and #6251.
Adds Ipv8Component.make_bootstrapper() factory and uses it for each community

@kozlovsky kozlovsky added this to the 7.11.0 September milestone Aug 12, 2021
@kozlovsky kozlovsky requested review from devos50 and qstokkink August 12, 2021 15:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kozlovsky
Copy link
Contributor Author

Retest this please

qstokkink
qstokkink approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@kozlovsky kozlovsky merged commit 5cb1ee0 into Tribler:main Aug 13, 2021
@kozlovsky kozlovsky deleted the fix/bootstrappers branch August 13, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qstokkink qstokkink qstokkink approved these changes

@devos50 devos50 Awaiting requested review from devos50

Assignees
No one assigned
Labels
None yet
Milestone
7.11.0 October
Development

Successfully merging this pull request may close these issues.

All Communities are using a single bootstrapper
2 participants
@kozlovsky @qstokkink