Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tunnel helper arguments #6293

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

kozlovsky
Copy link
Contributor

This PR fixes missed the first argument when raising the ArgumentError exception, and also it creates an ipaddress.IPv4Address instance instead of calling the inet_aton() function.

Also, it reformats the code a bit to satisfy the linter.

@kozlovsky kozlovsky added this to the 7.11.0 September milestone Aug 25, 2021
@kozlovsky kozlovsky requested a review from qstokkink August 25, 2021 11:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 Thanks!

@kozlovsky kozlovsky merged commit c7e3345 into Tribler:main Aug 25, 2021
@kozlovsky kozlovsky deleted the fix/run_tunnel_helper_arguments branch August 25, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants