Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6271 #6323

Merged
merged 3 commits into from
Sep 20, 2021
Merged

Fix #6271 #6323

merged 3 commits into from
Sep 20, 2021

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Sep 17, 2021

Fixes #6271 by splitting Debug endpoint initialization and disabling Profiler button in Debug window when Profiler is disabled in the Core

@ichorid ichorid marked this pull request as ready for review September 17, 2021 11:04
@ichorid ichorid marked this pull request as draft September 17, 2021 11:05
@ichorid
Copy link
Contributor Author

ichorid commented Sep 17, 2021

retest this please

@ichorid ichorid marked this pull request as ready for review September 17, 2021 13:16
@ichorid ichorid requested a review from xoriole September 17, 2021 13:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@ichorid
Copy link
Contributor Author

ichorid commented Sep 20, 2021

retest this please

1 similar comment
@ichorid
Copy link
Contributor Author

ichorid commented Sep 20, 2021

retest this please

@ichorid ichorid merged commit 12e2403 into Tribler:main Sep 20, 2021
@ichorid ichorid deleted the fix_6271 branch September 20, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoriole xoriole xoriole approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[main] GUI errors when running with [resource_monitor] enabled = False
2 participants
@ichorid @xoriole