Various small fixes #6372
Merged
Various small fixes #6372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichorid
force-pushed
the
small_fixes
branch
from
924c62a to
913604b
Compare
ichorid
requested review from
a team,
kozlovsky and
devos50
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed!
|
kozlovsky
reviewed
Sep 28, 2021
| # button, by the moment the request callback triggers some actions on the model, | ||
| # QT could have already deleted the underlying model object, which will result in | ||
| # "wrapped C/C++ object has been deleted" error (see e.g. https://github.com/Tribler/tribler/issues/6083) | ||
| for data, method in ((patch_data, "PATCH"), (delete_data, "DELETE")): |
There was a problem hiding this comment.
IMO, unrolled for-loop looks a bit more clear here
There was a problem hiding this comment.
Well, that way I'd have to repeat the comment twice 😉
kozlovsky
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6369
fixes #6366
fixes #6368
fixes #6083
fixes #6213
fixes #5886