Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly reduced the number of redraws in GUI tables #6384

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Sep 28, 2021

We used to repaint all (visible) rows when moving the mouse through the table with content. This PR significantly reduces the number of repaints by only repainting the index that has been changed in the table. In GUI test mode, scrolling through the table of content feels much smoother now.

Fixes #6377

We used to repaint all (visible) rows when moving the mouse through the table with content. This PR significantly reduces the number of repaints by selectively repainting the index that has been changed. In GUI test mode, it scrolls much smoother now.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devos50 devos50 changed the title Significantly reduced number of redraws in GUI Significantly reduced number of redraws in GUI tables Sep 28, 2021
@devos50 devos50 changed the title Significantly reduced number of redraws in GUI tables Significantly reduced the number of redraws in GUI tables Sep 28, 2021
@devos50 devos50 marked this pull request as ready for review September 28, 2021 16:59
@devos50 devos50 requested review from a team and kozlovsky and removed request for a team September 28, 2021 16:59
@ichorid ichorid merged commit 6499c14 into Tribler:main Sep 28, 2021
@devos50 devos50 deleted the minimized_draw_operations branch September 28, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TriblerButtonsDelegate is repainting all table rows on mouse movement
2 participants