Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed scrolling in GUI tables #6392

Merged
merged 2 commits into from
Sep 30, 2021
Merged

Fixed scrolling in GUI tables #6392

merged 2 commits into from
Sep 30, 2021

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented Sep 30, 2021

This PR fixes two issues:

  • When scrolling through the GUI tables, the old row would sometimes not be deselected. I fixed this by repainting the old hovered row entirely.
  • When scrolling through the GUI tables without moving the mouse, the new row selection would be incomplete (e.g., only a particular cell would be highlighted). I addressed this by emitting a mouse move event when scrolling.

@devos50
Fixed row deselection when scrolling/moving mouse
bda2c3f 
When the mouse changed row position, we should fully redraw the formerly hovered row to correctly deselect it.
@devos50
Fixed row selection when scrolling
4e707ce
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devos50 devos50 marked this pull request as ready for review September 30, 2021 08:57
@devos50 devos50 requested review from a team and drew2a and removed request for a team September 30, 2021 08:57
@devos50 devos50 merged commit 8e59701 into Tribler:main Sep 30, 2021
@devos50 devos50 deleted the fix_gui_scroll_selection branch September 30, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichorid ichorid ichorid approved these changes

@drew2a drew2a Awaiting requested review from drew2a

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devos50 @ichorid