Modified shutdown procedure in GUI tests #6448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR, I slightly modify the shutdown procedure in the GUI tests. I dived a bit into the shutdown procedure when I triggered a segmentation fault in Qt when using dynamic row heights for tags (by overriding the sizeHint method). This segmentation fault would trigger in ~10% of the test runs, and by investigating the (fortunately, symbolicated!) stack trace, it seems to happen when Qt tries to do a final render operation when closing the Qt application. While a more effective solution is probably out of reach for now, it seems that we can workaround this by more gracefully shutting down the components in the GUI tests. I also believe this is a more reliable approach to unload the GUI tests. Specifically, this PR ensures that we move to the 'shutting down' screen in the GUI when the GUI tests are done (and a screenshot is also made). Then, we shutdown the core. Only when the core process is finished, we close the Qt application. Also, by making the `window` fixture dependent on the `tribler_api` fixture, I was able to remove the `tribler_api` fixture declaration from the test methods.
devos50
force-pushed
the
change_gui_test_shutdown
branch
from
06b0fae to
4e8e45f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
devos50
requested review from
a team and
xoriole
and removed request for
a team
ichorid
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I slightly modify the shutdown procedure in the GUI tests. I dived a bit into the shutdown procedure when I triggered a segmentation fault in Qt when using dynamic row heights for tags (by overriding the sizeHint method). This segmentation fault would trigger in ~10% of the test runs, and by investigating the (fortunately, symbolicated!) stack trace, it seems to happen when Qt tries to do a final render operation when closing the Qt application. While a more effective solution is probably out of reach for now, it seems that we can workaround this by more gracefully shutting down the components in the GUI tests. I also believe this is a more reliable approach to unload the GUI tests.
Specifically, this PR ensures that we move to the 'shutting down' screen in the GUI when the GUI tests are done (and a screenshot is also made). Then, we shutdown the core. Only when the core process is finished, we close the Qt application.
Also, by making the
windowfixture dependent on thetribler_apifixture, I was able to remove thetribler_apifixture declaration from the test methods.