Add Secondary Key to MasterKeyComponent #6462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
changed the title
|
Why not use the Derived Keys functionality of LibNaCl for this? |
drew2a
force-pushed
the
feature/alter_ego
branch
3 times, most recently
from
1921756 to
c2e7f80
Compare
drew2a
requested review from
a team,
ichorid and
devos50
and removed request for
a team
ichorid
previously approved these changes
Oct 18, 2021
devos50
reviewed
Oct 18, 2021
src/tribler-core/tribler_core/components/masterkey/masterkey_component.py
Outdated
Show resolved
Hide resolved
drew2a
force-pushed
the
feature/alter_ego
branch
from
4088562 to
b02e00b
Compare
|
I suspect the whole PR could be replaced with a single line of: Hmm... 🤔 |
It is not possible, because this PR contains not only new logic for a MasterKeyComponent (which can be implemented in one line), but also refactoring and changes to the TagCommunity. |
drew2a
force-pushed
the
feature/alter_ego
branch
2 times, most recently
from
0e9c84d to
66ba43e
Compare
devos50
reviewed
Oct 19, 2021
drew2a
force-pushed
the
feature/alter_ego
branch
from
66ba43e to
716ae65
Compare
drew2a
force-pushed
the
feature/alter_ego
branch
from
716ae65 to
ab38f20
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
devos50
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Secondary Key to the MasterKeyComponent.
In PR:
Related to #6214 and addresses the anonymity issue of associating content with Public Key and IP.