Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #6494

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Oct 25, 2021

This PR fixes #6489 by removing unused code.

@drew2a drew2a force-pushed the refactoring/remove_unused_code branch from 3d54ae3 to 3b073fc Compare October 25, 2021 12:32
@drew2a drew2a requested review from ichorid and xoriole October 25, 2021 13:08
@drew2a drew2a marked this pull request as ready for review October 25, 2021 13:09
@drew2a drew2a requested a review from a team October 25, 2021 13:09
@drew2a drew2a force-pushed the refactoring/remove_unused_code branch 2 times, most recently from 73cea58 to aee5b99 Compare October 25, 2021 13:13
ichorid
ichorid previously approved these changes Oct 25, 2021
Copy link
Contributor

@ichorid ichorid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! 👍 So much cruft!

@drew2a drew2a force-pushed the refactoring/remove_unused_code branch from d803fec to 6a77109 Compare October 26, 2021 07:58
@drew2a drew2a requested review from xoriole and ichorid October 26, 2021 08:27
ichorid
ichorid previously approved these changes Oct 26, 2021
@drew2a drew2a force-pushed the refactoring/remove_unused_code branch 2 times, most recently from 0dbfbab to 0329325 Compare October 27, 2021 09:08
@drew2a drew2a marked this pull request as draft October 27, 2021 09:13
@drew2a drew2a force-pushed the refactoring/remove_unused_code branch from a165984 to 527aa60 Compare October 27, 2021 09:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drew2a drew2a marked this pull request as ready for review October 27, 2021 10:04
@drew2a
Copy link
Contributor Author

drew2a commented Oct 27, 2021

I've fixed pylint and flake issues and removed a few unused Exceptions. So, please, review it again.

@drew2a drew2a requested a review from ichorid October 27, 2021 10:06
@drew2a drew2a merged commit b77b642 into Tribler:main Oct 27, 2021
@drew2a drew2a deleted the refactoring/remove_unused_code branch October 27, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Tribler's dead code
3 participants