-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused code #6494
Merged
Merged
Remove unused code #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
refactoring/remove_unused_code
branch
from
October 25, 2021 12:32
3d54ae3
to
3b073fc
Compare
drew2a
force-pushed
the
refactoring/remove_unused_code
branch
2 times, most recently
from
October 25, 2021 13:13
73cea58
to
aee5b99
Compare
xoriole
reviewed
Oct 25, 2021
ichorid
reviewed
Oct 25, 2021
src/tribler-core/tribler_core/components/gigachannel/community/request.py
Show resolved
Hide resolved
ichorid
previously approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! 👍 So much cruft!
drew2a
force-pushed
the
refactoring/remove_unused_code
branch
from
October 26, 2021 07:58
d803fec
to
6a77109
Compare
ichorid
previously approved these changes
Oct 26, 2021
drew2a
force-pushed
the
refactoring/remove_unused_code
branch
2 times, most recently
from
October 27, 2021 09:08
0dbfbab
to
0329325
Compare
drew2a
force-pushed
the
refactoring/remove_unused_code
branch
from
October 27, 2021 09:35
a165984
to
527aa60
Compare
Kudos, SonarCloud Quality Gate passed! |
I've fixed pylint and flake issues and removed a few unused Exceptions. So, please, review it again. |
ichorid
approved these changes
Oct 27, 2021
xoriole
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6489 by removing unused code.