Fixes #6263 - Tribler should open FeedbackDialog if error happend in Core during startup #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
reviewed
Nov 5, 2021
src/tribler-core/tribler_core/components/restapi/rest/events_endpoint.py
Outdated
Show resolved
Hide resolved
drew2a
reviewed
Nov 5, 2021
src/tribler-core/tribler_core/components/restapi/rest/events_endpoint.py
Outdated
Show resolved
Hide resolved
drew2a
reviewed
Nov 5, 2021
src/tribler-core/tribler_core/components/restapi/rest/events_endpoint.py
Outdated
Show resolved
Hide resolved
kozlovsky
force-pushed
the
fix/6263_report_error_on_startup_crash
branch
from
9652358 to
b63ee20
Compare
…end in Core during startup
kozlovsky
force-pushed
the
fix/6263_report_error_on_startup_crash
branch
from
b63ee20 to
61ab37b
Compare
drew2a
previously approved these changes
Nov 5, 2021
|
retest this please |
test_on_tribler_exception_stores_only_first_error test_get_events_has_undelivered_error
|
Kudos, SonarCloud Quality Gate passed!
|
drew2a
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6263. The error that happened too early during the core startup process may get lost if GUI connects to Core after Core processes the exception. This PR remembers the last error and reports it to GUI on connect. Also, it refactors the code of
EventsEndpointto make it more readable.