Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pip dependencies during the build #6534

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Install pip dependencies during the build #6534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions build/debian/makedist_debian.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ rm -rf build/debian/tribler/usr/share/tribler

python3 build/update_version_from_git.py

# ----- Install pip dependencies before the build
python3 -m pip install --upgrade -r src/requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: we should stop the build procedure in case of pip install error.

The possible, but not tested solution:

Suggested change
python3 -m pip install --upgrade -r src/requirements.txt
python3 -m pip install --upgrade -r src/requirements.txt || exit 1


python3 -m PyInstaller tribler.spec

cp -r dist/tribler build/debian/tribler/usr/share/tribler
Expand Down
3 changes: 3 additions & 0 deletions build/mac/makedist_macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ export RESOURCES=build/mac/resources
/bin/rm -rf dist

# ----- Build
# ----- Install pip dependencies before the build
python3 -m pip install --upgrade -r src/requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: we should stop the build procedure in case of pip install error.

The possible, but not tested solution:

Suggested change
python3 -m pip install --upgrade -r src/requirements.txt
python3 -m pip install --upgrade -r src/requirements.txt || exit 1


PI=pyinstaller
$PI tribler.spec

Expand Down
3 changes: 3 additions & 0 deletions build/win/makedist_win.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ call build\win\clean.bat

REM ----- Build

REM ----- Install pip dependencies before the build
python3 -m pip install --upgrade -r src\requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: we should stop the build procedure in case of pip install error.

The possible, but not tested solution:

Suggested change
python3 -m pip install --upgrade -r src\requirements.txt
python3 -m pip install --upgrade -r src\requirements.txt || EXIT /B 1


REM Arno: When adding files here, make sure tribler.nsi actually
REM packs them in the installer .EXE

Expand Down