Handle UnicodeDecodeError in logger when console encoding is not utf-8 #6672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
drew2a
and removed request for
a team
kozlovsky
force-pushed
the
fix/console_encoding_non_utf8
branch
3 times, most recently
from
90d9eea to
ef486e2
Compare
kozlovsky
force-pushed
the
fix/console_encoding_non_utf8
branch
from
ef486e2 to
d93dfa0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
retest this please |
1 similar comment
|
retest this please |
ichorid
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6671 by adding wrappers around
stdout&stderrthat can handleUnicodeEncodeError.