Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config refactoring #6879

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Config refactoring #6879

merged 1 commit into from
Apr 20, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Apr 20, 2022

This PR contains Tribler's config refactoring (mostly renaming).

Also, there is the simplification that @kozlovsky requested:

    def get_path_as_absolute(self, property_name: str, state_dir: Path = None) -> Optional[Path]:
        """ Get path as absolute. If stored value already in absolute form, then it will be returned in "as is".
           `state_dir / path` will be returned otherwise.
        """
        value = self.__getattribute__(property_name)
        if value is None:
            return None
        return state_dir / value

@drew2a drew2a force-pushed the feature/config_refactoring branch 2 times, most recently from 4b7e5c2 to e6cf792 Compare April 20, 2022 16:17
@drew2a drew2a requested a review from kozlovsky April 20, 2022 16:17
@drew2a drew2a force-pushed the feature/config_refactoring branch from e6cf792 to a26ae4e Compare April 20, 2022 16:18
@drew2a drew2a marked this pull request as ready for review April 20, 2022 16:18
@drew2a drew2a requested a review from a team April 20, 2022 16:18
@drew2a drew2a merged commit 864be46 into Tribler:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants