Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format_error_message function #6881

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Apr 21, 2022

This PR addresses #6810

This PR changes the error formatting style in "on_core_finished with an error".

Two changes:

  1. Added translation from err_code to strerror
  2. Added quoting for the last core output

An example of an error message:

The Tribler core has unexpectedly finished with exit code 2 and status: 2.

Error message: No such file or directory

Last core output:
> ERROR <loggingstuff:8> root.print_error(): Something went wrong!
> Traceback (most recent call last):,
>   File "ipv8  askmanager.py", line 131, in done_cb,
>   File "ipv8\messagingnonymization\hidden_services.py", line 366, in on_create_e2e,
>   File "ipv8\messagingnonymization\hidden_services.py", line 378, in create_created_e2e,
> KeyError: 1030643827

Ref:

@drew2a drew2a force-pushed the refactoring/format_error_message branch 2 times, most recently from fa72302 to 9e315a5 Compare April 21, 2022 12:47
@drew2a drew2a requested a review from kozlovsky April 21, 2022 13:03
@drew2a drew2a marked this pull request as ready for review April 21, 2022 13:04
@drew2a drew2a requested a review from a team April 21, 2022 13:04
@drew2a drew2a added this to the 7.13.0 April milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants