Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the sign step to the windows build #6946

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Add the sign step to the windows build #6946

merged 2 commits into from
Jun 29, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jun 22, 2022

This PR adds the sign step to the windows build.

The certificate is stored as an environment secret base64 string.

See:

To continue the build procedure (and to get access to the secret), the approval of reviewers is needed. These reviewers are listed in the "Build" environment: https://github.com/Tribler/tribler/settings/secrets/actions

The windows build procedure will be the following (after merging to the main):

image

image

@drew2a drew2a force-pushed the feature/sign_win_build branch 2 times, most recently from 6da68f0 to 7b6617a Compare June 22, 2022 20:01
@drew2a drew2a force-pushed the main branch 3 times, most recently from 2370caf to 21168b4 Compare June 23, 2022 11:54
@drew2a drew2a force-pushed the feature/sign_win_build branch 3 times, most recently from 4e3cf67 to 6673a6d Compare June 27, 2022 08:38
@drew2a drew2a marked this pull request as ready for review June 27, 2022 08:39
@drew2a drew2a requested review from a team, xoriole and kozlovsky and removed request for a team June 27, 2022 08:39
@drew2a drew2a merged commit 1a4e89b into main Jun 29, 2022
@drew2a drew2a deleted the feature/sign_win_build branch May 2, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants