Add resource_type for subjects in queries in the KnowledgeDatabase
#7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
changed the title
resource_type for subjects in queries in the KnowledgeDBresource_type for subjects in queries in the KnowledgeDatabase
drew2a
force-pushed
the
fix/resource_type
branch
from
ee7fbaa
to
21f7ef0
Compare
drew2a
force-pushed
the
fix/resource_type
branch
from
bd5563e
to
c0b283e
Compare
drew2a
requested review from
a team and
kozlovsky
and removed request for
a team
kozlovsky
suggested changes
Nov 14, 2022
drew2a
force-pushed
the
fix/resource_type
branch
2 times, most recently
from
bc043af
to
1e74b0a
Compare
kozlovsky
force-pushed
the
fix/resource_type
branch
from
6a97743
to
5aa0ef6
Compare
drew2a
force-pushed
the
fix/resource_type
branch
from
5aa0ef6
to
8ed7b4b
Compare
kozlovsky
approved these changes
Nov 21, 2022
Co-authored-by: Alexander Kozlovsky <alexander.kozlovsky@gmail.com>
Co-authored-by: Alexander Kozlovsky <alexander.kozlovsky@gmail.com>
drew2a
force-pushed
the
fix/resource_type
branch
from
8ed7b4b
to
3619ca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kozlovsky requested this change for
KnowledgeDatabase.He has noticed that methods like
get_subjects,get_objects,get_statements,get_suggestionshave missed thesubject_typeargument.Therefore it was technically possible to have two subjects like
2002both in the title and in the tag (for example). This possibility could cause confusion in the future.The next step in this line of thought would be adding a mandatory type for all returning values.