Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflows context #7267

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Fix workflows context #7267

merged 1 commit into from
Jan 16, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jan 14, 2023 •
edited
Loading

This PR fixes the incorrect use of context that was introduced in #7186

Now a PR workflow is the following:

  1. GitHub actions checkout the code of the target branch (usually it is main)
  2. The gatekeeper job checks that the author of the PR has a write-access to the repo or the PR has a label PR: safe to check
  3. GitHub actions checkout the code of the source branch
  4. GitHub actions execute all the checks (with read-only permissions) by using the source branch

This PR unmask the error described here #7265

The checks in this PR are failed. It is intended, because this fix has to be in the 'main' branch to be applied.

@drew2a drew2a marked this pull request as ready for review January 16, 2023 08:52
@drew2a drew2a requested review from a team, xoriole and kozlovsky and removed request for a team and xoriole January 16, 2023 08:52
@drew2a drew2a merged commit 9a2ee03 into main Jan 16, 2023
@drew2a drew2a deleted the fix/workflow_context branch January 16, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drew2a @kozlovsky