Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extends ResultItem by timestamp #8202

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Extends ResultItem by timestamp #8202

merged 1 commit into from
Oct 22, 2024

Conversation

mg98
Copy link
Contributor

@mg98 mg98 commented Oct 10, 2024

This PR:

  • Adds timestamps to query logs

@mg98 mg98 changed the title Extended ResultItem by timestamp Extends ResultItem by timestamp Oct 10, 2024
egbertbouman
egbertbouman reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@egbertbouman egbertbouman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the unittests and a few minor comments.

src/tribler/test_unit/core/recommender/test_manager.py Outdated Show resolved Hide resolved
src/tribler/core/recommender/community.py Show resolved Hide resolved
@qstokkink qstokkink marked this pull request as draft October 11, 2024 10:08
@mg98 mg98 force-pushed the feat/extend-resultitem branch 2 times, most recently from 90b8b43 to aa6e6c3 Compare October 16, 2024 13:57
@qstokkink
Copy link
Contributor

@mg98 Could you fix your commit history?

@mg98 mg98 force-pushed the feat/extend-resultitem branch from aa6e6c3 to 62fa9f1 Compare October 21, 2024 14:45
@mg98 mg98 marked this pull request as ready for review October 21, 2024 14:50
@qstokkink qstokkink merged commit f377d1a into Tribler:main Oct 22, 2024
7 checks passed
@mg98 mg98 deleted the feat/extend-resultitem branch October 22, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mg98 @qstokkink @egbertbouman