Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed various upgrade issues #8297

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fixed various upgrade issues #8297

merged 1 commit into from
Dec 2, 2024

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Dec 2, 2024 •
edited
Loading

Fixes #8283
Fixes #8289

This PR:

  • Fixes KnowledgeCommunity.on_message not using serializable=True, causing Database is locked errors.
  • Fixes upgrade_script not being guarded by db_session because the Database is outside of Pony's control, causing Database is locked errors.
  • Fixes dlcheckpoints appearing as a Tribler version.
  • Fixes calling perform_upgrade() twice causing an unhandled exception.
  • Updates the versioning page to not wait several seconds before showing an update is in progress.
  • Updates the version upgrade to operate in batches, not all database content at once.

@qstokkink qstokkink force-pushed the fix_empty_state_table_upgrade branch from 8cb62d8 to 03ce665 Compare December 2, 2024 12:58
@qstokkink qstokkink marked this pull request as ready for review December 2, 2024 13:04
@qstokkink qstokkink changed the title WIP: Fixed various upgrade issues READY: Fixed various upgrade issues Dec 2, 2024
egbertbouman
egbertbouman approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@egbertbouman egbertbouman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have database performance issues, I'm a bit worried about the serializable=True causing even more resource usage. But it's certainly better than the database locking up.

@qstokkink qstokkink changed the title READY: Fixed various upgrade issues Fixed various upgrade issues Dec 2, 2024
@qstokkink qstokkink merged commit b3bd53d into Tribler:main Dec 2, 2024
7 checks passed
@qstokkink qstokkink deleted the fix_empty_state_table_upgrade branch December 2, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tribler WebUI not loading issue report
2 participants
@qstokkink @egbertbouman