Rein in KnowledgeCommunity peer count #8304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
changed the title
qstokkink
force-pushed
the
upd_knwldg_peer_limit
branch
2 times, most recently
from
31b2f3b to
4a8017d
Compare
qstokkink
force-pushed
the
upd_knwldg_peer_limit
branch
from
4a8017d to
bd0175b
Compare
qstokkink
changed the title
egbertbouman
approved these changes
Dec 4, 2024
qstokkink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8292
This PR:
KnowledgeCommunityto more aggressively ward off superfluous peers.From my local tests, this is enough to keep the peer count under control. In the worst case, we can also blacklist/ban peers: but this does not seem necessary (yet).