more ignoring the linter (#32)

Insecure random number generation isn't a problem in tests.
TriggerMail · Jun 18, 2024 · 70f4b10 · 70f4b10
1 parent beb671b
commit 70f4b10
Show file tree

Hide file tree

Showing 10 changed files with 21 additions and 20 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 .vscode/
 .DS_Store
 test-results/
+dist/
diff --git a/bench/lazylru_benchmark_test.go b/bench/lazylru_benchmark_test.go
@@ -48,8 +48,8 @@ func (bc benchconfig) Generic(b *testing.B) {
 	runtime.GC()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		ix := rand.IntN(bc.keyCount)
-		if rand.Float64() < bc.readRate {
+		ix := rand.IntN(bc.keyCount)      //nolint:gosec
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			lru.Get(keys[ix])
 		} else {
 			lru.Set(keys[ix], ix)
@@ -67,8 +67,8 @@ func (bc benchconfig) GenInterface(b *testing.B) {
 	runtime.GC()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		ix := rand.IntN(bc.keyCount)
-		if rand.Float64() < bc.readRate {
+		ix := rand.IntN(bc.keyCount)      //nolint:gosec
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			lru.Get(keys[ix])
 		} else {
 			lru.Set(keys[ix], ix)

diff --git a/bench/test_data.go b/bench/test_data.go
@@ -9,7 +9,7 @@ const validChars = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ01234567
 func randomString(size int) string {
 	retval := make([]byte, size)
 	for i := 0; i < len(retval); i++ {
-		retval[i] = validChars[rand.IntN(len(validChars))]
+		retval[i] = validChars[rand.IntN(len(validChars))] //nolint:gosec
 	}
 	return string(retval)
 }
@@ -40,7 +40,7 @@ func NewTestData(count int) TestDataSimple {
 
 // RandomKV retrieves a random key/value pair
 func (td TestDataSimple) RandomKV() (string, string) {
-	kv := td[rand.IntN(len(td))]
+	kv := td[rand.IntN(len(td))] //nolint:gosec
 	return kv.Key, kv.Value
 }
 

diff --git a/containers/heap/heap_test.go b/containers/heap/heap_test.go
@@ -202,7 +202,7 @@ func TestFix(t *testing.T) {
 	h.verify(t, 0)
 
 	for i := 100; i > 0; i-- {
-		elem := rand.IntN(h.Len())
+		elem := rand.IntN(h.Len()) //nolint:gosec
 		if i&1 == 0 {
 			(*h)[elem] *= 2
 		} else {

diff --git a/generic/containers/heap/heap_test.go b/generic/containers/heap/heap_test.go
@@ -202,7 +202,7 @@ func TestFix(t *testing.T) {
 	h.verify(t, 0)
 
 	for i := 100; i > 0; i-- {
-		elem := rand.IntN(h.Len())
+		elem := rand.IntN(h.Len()) //nolint:gosec
 		if i&1 == 0 {
 			(*h)[elem] *= 2
 		} else {

diff --git a/generic/lazylru.go b/generic/lazylru.go
@@ -176,7 +176,7 @@ func (lru *LazyLRU[K, V]) reap(start int, deathList []*item[K, V]) {
 			break
 		}
 		if start < 0 {
-			start = rand.IntN(len(lru.items))
+			start = rand.IntN(len(lru.items)) //nolint:gosec
 		}
 		end := start + 100 // why 100? no idea
 		if end > len(lru.items) {

diff --git a/generic/lazylru_benchmark_test.go b/generic/lazylru_benchmark_test.go
@@ -62,7 +62,7 @@ func (bc benchconfig) InterfaceArray(b *testing.B) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		ix := i % bc.keyCount
-		if rand.Float64() < bc.readRate {
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			// if true {
 			if iv, ok := lru.Get(keys[ix]); !ok {
 				continue
@@ -91,7 +91,7 @@ func (bc benchconfig) GenericArray(b *testing.B) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		ix := i % bc.keyCount
-		if rand.Float64() < bc.readRate {
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			// if true {
 			if v, ok := lru.Get(keys[ix]); !ok {
 				continue
@@ -114,7 +114,7 @@ func (bc benchconfig) InterfaceStructPtr(b *testing.B) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		ix := i % bc.keyCount
-		if rand.Float64() < bc.readRate {
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			// if true {
 			if iv, ok := lru.Get(keys[ix]); !ok {
 				continue
@@ -143,7 +143,7 @@ func (bc benchconfig) GenericStructPtr(b *testing.B) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		ix := i % bc.keyCount
-		if rand.Float64() < bc.readRate {
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			// if true {
 			if v, ok := lru.Get(keys[ix]); !ok {
 				continue
@@ -166,7 +166,7 @@ func (bc benchconfig) InterfaceValue(b *testing.B) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		ix := i % bc.keyCount
-		if rand.Float64() < bc.readRate {
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			// if true {
 			if iv, ok := lru.Get(keys[ix]); !ok {
 				continue
@@ -195,7 +195,7 @@ func (bc benchconfig) GenericValue(b *testing.B) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		ix := i % bc.keyCount
-		if rand.Float64() < bc.readRate {
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			// if true {
 			if v, ok := lru.Get(keys[ix]); !ok {
 				continue

diff --git a/generic/sharded/lazylru_benchmark_test.go b/generic/sharded/lazylru_benchmark_test.go
@@ -70,8 +70,8 @@ func (bc benchconfig) Run(b *testing.B) {
 	for c := 0; c < bc.concurrency; c++ {
 		go func(c int) {
 			for i := c; i < b.N; i += bc.concurrency {
-				ix := rand.IntN(bc.keyCount)
-				if rand.Float64() < bc.readRate {
+				ix := rand.IntN(bc.keyCount)      //nolint:gosec
+				if rand.Float64() < bc.readRate { //nolint:gosec
 					lru.Get(keys[ix])
 				} else {
 					lru.Set(keys[ix], ix)

diff --git a/lazylru_benchmark_test.go b/lazylru_benchmark_test.go
@@ -195,7 +195,7 @@ func (bc benchconfig) GenericValue(b *testing.B) {
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
 		ix := i % bc.keyCount
-		if rand.Float64() < bc.readRate {
+		if rand.Float64() < bc.readRate { //nolint:gosec
 			// if true {
 			if v, ok := lru.Get(keys[ix]); !ok {
 				continue

diff --git a/sharded/lazylru_benchmark_test.go b/sharded/lazylru_benchmark_test.go
@@ -70,8 +70,8 @@ func (bc benchconfig) Run(b *testing.B) {
 	for c := 0; c < bc.concurrency; c++ {
 		go func(c int) {
 			for i := c; i < b.N; i += bc.concurrency {
-				ix := rand.IntN(bc.keyCount)
-				if rand.Float64() < bc.readRate {
+				ix := rand.IntN(bc.keyCount)      //nolint:gosec
+				if rand.Float64() < bc.readRate { //nolint:gosec
 					lru.Get(keys[ix])
 				} else {
 					lru.Set(keys[ix], ix)