Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Issue #84 - Weight Tracker #92

Closed
wants to merge 6 commits into from
Closed

Conversation

Alumniminium
Copy link
Contributor

@Alumniminium Alumniminium commented Jul 8, 2024

Here's my updated weight-tracker.md to close #84 and close #14

I've fixed the grammar, markdown headings and rewrote it a bit.

Someone else might want to add a new screenshot?

Copy link
Contributor

@root-hal9000 root-hal9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is already a lot more clear/consistent than the original. I made some minor suggestions, mostly optional, that I think help even further in terms of clarity.

Wiki/weight-tracker.md Outdated Show resolved Hide resolved
Wiki/weight-tracker.md Outdated Show resolved Hide resolved
Wiki/weight-tracker.md Outdated Show resolved Hide resolved
Wiki/weight-tracker.md Outdated Show resolved Hide resolved
@root-hal9000
Copy link
Contributor

@Alumniminium I just noticed that this is actually a PR into main from initial-review. I thought we were doing them from other branches/our forks into initial-review, then just doing a big merge into main at the end of the project? I don't know what's better TBH, I just proposed to merge everything into initial review in the discussion I had posted and no one mentioned anything to the contrary, so I just assumed we were going with that. I can't commit to the repo anyway, so I am just doing from my fork into initial-review

@Alumniminium
Copy link
Contributor Author

Alumniminium commented Jul 9, 2024

I thought we were doing them from other branches/our forks into initial-review

Ah yes, that would make a lot more sense. I was a bit confused what you had in mind. Will do that in the future. I'll just close this PR and not merge it.

Thanks for your changes. I'll make sure to include your changes! One day my english will be up to standards :D

@root-hal9000
Copy link
Contributor

One day my english will be up to standards :D

Come on, it was really good and clean! I was just being a very picky editor :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc Review: Weight-tracker.md Doc Review: Advanced showcases.md
2 participants