Batch 2 #98
Merged
Batch 2 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. I didn't mean to push to your branch (I didn't even think that would be possible). I'm not very used to the process of suggesting changes via VSCode. I thought i would have pushed my changes to my own Initial-Review branch and then submit a merge request to your Initial-Review branch, but apparently my remotes weren't setup correctly. I suppose if you're ok with the minor changes I made, then we should still be good to merge. |
meichthys
approved these changes
Jul 28, 2024
Alumniminium
commented
Jul 28, 2024
Yeah, I have no clue why I was able to push to your fork, perhaps there was an option on your merge request to allow maintainers to edit your branch? I think I've seen that before 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abuse me @root-hal9000