client: Hide spellcheck settings on web (closes #345)

TriliumNext · Aug 16, 2024 · ca6b4c3 · ca6b4c3
1 parent 1172908
commit ca6b4c3
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/integration-tests/settings.spec.ts b/integration-tests/settings.spec.ts
@@ -10,4 +10,12 @@ test("Tray settings not displayed on web", async ({ page }) => {
     await page.goto('http://localhost:8082/#root/_hidden/_options/_optionsOther');
     await expect(page.getByRole('heading', { name: 'Note Erasure Timeout' })).toBeVisible();
     await expect(page.getByRole('heading', { name: 'Tray' })).toBeHidden();
+});
+
+test("Spellcheck settings not displayed on web", async ({ page }) => {
+    await page.goto('http://localhost:8082/#root/_hidden/_options/_optionsSpellcheck');
+    await expect(page.getByRole('heading', { name: 'Spell Check' })).toBeVisible();
+    await expect(page.getByRole('heading', { name: 'Tray' })).toBeHidden();
+    await expect(page.getByText('These options apply only for desktop builds')).toBeVisible();
+    await expect(page.getByText('Enable spellcheck')).toBeHidden();
 });
diff --git a/src/public/app/widgets/type_widgets/options/spellcheck.js b/src/public/app/widgets/type_widgets/options/spellcheck.js
@@ -1,11 +1,19 @@
 import utils from "../../../services/utils.js";
 import OptionsWidget from "./options_widget.js";
 
-const TPL = `
+const TPL_WEB = `
 <div class="options-section">
     <h4>Spell Check</h4>
 
-    <p>These options apply only for desktop builds, browsers will use their own native spell check. App restart is required after change.</p>
+    <p>These options apply only for desktop builds, browsers will use their own native spell check.</p>
+</div>
+`;
+
+const TPL_ELECTRON = `
+<div class="options-section">
+    <h4>Spell Check</h4>
+
+    <p>App restart is required after change.</p>
 
     <label>
         <input type="checkbox" class="spell-check-enabled">
@@ -26,7 +34,8 @@ const TPL = `
 
 export default class SpellcheckOptions extends OptionsWidget {
     doRender() {
-        this.$widget = $(TPL);
+        const template = utils.isElectron() ? TPL_ELECTRON : TPL_WEB;
+        this.$widget = $(template);
 
         this.$spellCheckEnabled = this.$widget.find(".spell-check-enabled");
         this.$spellCheckLanguageCode = this.$widget.find(".spell-check-language-code");