Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature request) Syntax highlight for code blocks #20

Closed
eliandoran opened this issue Feb 17, 2024 · 4 comments
Closed

(Feature request) Syntax highlight for code blocks #20

eliandoran opened this issue Feb 17, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@eliandoran
Copy link
Contributor

eliandoran commented Feb 17, 2024

Describe feature

This goes without saying, it's one of the most requested features from the people I've known using Trilium for taking notes related to software development.

Additional Information

Some notes I've took in the past:

Apparently the syntax highlighting is not supported in the CKEditor, which is the reason that code blocks within text notes do not have syntax highlight.

  • Syntax highlighting on code blocks? #1803

Some works has already been done to try to integrate some kind of syntax highlight in CKEditor:

  • Added syntax highlighting to code-blocks (and it works!) #2198
    • Huge amount of changes (-11k deletions).
    • Only a proof of concept, not meant to be merged.
  • [Widget] Syntax Highlight Widget #2822
    • This is actually a fully-fledged implementation which uses highlight.js.
    • Works as a custom script.
    • Seems quite good, actually, although its README is out of date.
@liuxiawei
Copy link

Thanks to these efforts, can we realize the display of line numbers?

@meichthys
Copy link
Contributor

Being worked on in #526

@eliandoran
Copy link
Contributor Author

Done in #526.

@eliandoran
Copy link
Contributor Author

@liuxiawei ,

Thanks to these efforts, can we realize the display of line numbers?

Unfortunately no, the syntax highlighting takes care only of the coloring. Numbering code blocks is not something I'm particularly interested in, since usually you would use a full-fledged code note should you require a file that contains too many lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants