Enable MacOS code signing and notarization in GitHub Actions #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pano9000
reviewed
Feb 24, 2025
| ? path.join(buildPath, `${APP_NAME}.app`, "Contents", "Resources", baseName) | ||
| : path.join(buildPath, "resources", baseName); | ||
|
|
||
| // prettier-ignore |
There was a problem hiding this comment.
could you add that comment back in above destPath please?
There was a problem hiding this comment.
I believe I put it back where you asked, now 👀
|
That (because it moved files around in the So we'll want to keep that in mind if we ever want to sign Windows, that we'll need to modify that |
eliandoran
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working CI/CD
https://github.com/perfectra1n/Notes/actions/runs/13488732370/job/37683473246#step:4:931
Release objects associated with above CI/CD run:
https://github.com/perfectra1n/Notes/releases/tag/v2.0.8
Closes #329.