Update Electron dependencies #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 17, 2024
Closed
eliandoran
force-pushed
the
feature/update_electron
branch
from
95d2129 to
9bc89ff
Compare
|
I'll give it a closer look later but from a preliminary look nothing jumps out at me, this is a good change |
|
@rauenzi , I've "discovered" that the update of |
|
Ah that is indeed quite a major implication... I would be hesitant to go forward with it if we're to get any initial adoption/migration of users. |
Avoids an import error because electron-debug became ESM-only in version 4. We will update to it once we upgrade to ESM.
eliandoran
force-pushed
the
feature/update_electron
branch
from
0633039 to
9db4e1d
Compare
Closed
|
@rauenzi , OK, split the @TriliumNext/development , please review. Artifacts available here: https://github.com/TriliumNext/Notes/actions/runs/10020074760 |
eliandoran
changed the title
better-sqlite3This reverts commit 776d2e7.
…eature/update_electron
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
electron-debug, norelectron-dlcan be updated for now, since they have become ESM-only, causing a crash at start-up. They can be updated once we have ESM in the server (see Port server to ES modules #15).