-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger full text search when Ctrl + Enter is pressed in note autocomplete #585
Conversation
Hi, @SiriusXT . Could you please provide a little bit more context about this PR?
|
|
…into sirius_patch_2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think instead of adding Ctrl+Enter for a full text search to have an entry underneath "Create and link child note 'foo'" that says "Search for 'foo'" (or similar)? I'm afraid altering the placeholder will turn the text longer and harder to interpret. And I don't think it will affect efficiency too much, since it will be arrow down + enter instead of Ctrl + Enter.
@SiriusXT , looks perfect now. I was thinking as a future improvement to the search function, maybe we could add icons to the two special actions? Or even add icons of the notes. |
When searching for notes, title search sometimes fails to find the desired note.
This PR enables full-text search directly by pressing Ctrl + Enter.