Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak menus #618

Merged
merged 27 commits into from
Nov 20, 2024
Merged

Tweak menus #618

merged 27 commits into from
Nov 20, 2024

Conversation

adoriandoran
Copy link
Member

@adoriandoran adoriandoran commented Nov 20, 2024

  • Reordered and grouped the menu items to improve the user experience;
  • Added missing icons;
  • Improved the appearance of menus (added a shadow and reduced the contrast of separators);
  • Added a fade animation when opening menus;
  • Added a delay for opening submenus.

image

@SiriusXT
Copy link
Contributor

I feel like almost every time I open the launcher menu, it's because I need to access the options. Wouldn't it be better to place the options at the top?

@adoriandoran
Copy link
Member Author

I feel like almost every time I open the launcher menu, it's because I need to access the options. Wouldn't it be better to place the options at the top?

I often open this menu primarily for the options as well. However, according to common design conventions, the options menu item is usually placed near the end of the menu. Here are some examples from the main menus of Firefox, Chrome, and Opera:

image

@SiriusXT
Copy link
Contributor

SiriusXT commented Nov 20, 2024

It might be better to put options somewhere above Advanced, otherwise every time the mouse passes over Advanced it triggers the secondary menu.

Or delay the display of the secondary menu?

Of course, it's fine to put it below

@adoriandoran
Copy link
Member Author

I think delaying the sub-menu would be better, as it would also benefit other menus. I'll look into it.

@meichthys
Copy link
Contributor

I feel like almost every time I open the launcher menu, it's because I need to access the options

^this, but I do agree with having the settings near the bottom. I think we could improve access to settings by adding settings to the available launchers in the sidebar.

@SiriusXT
Copy link
Contributor

图片
图片
This red icon is rather too attention-grabbing and gives me an urge to click on it.

I checked VSCode, PyCharm, and Obsidian, and they all place the "Close Tab" related actions above the "Move to New Window" option. I also think placing it at the top better aligns with user habits.

Copy link
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eliandoran eliandoran merged commit ae85bff into develop Nov 20, 2024
1 check passed
@eliandoran eliandoran deleted the feat/tweak-menus branch November 20, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants