Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the Attribute to be Checked in Find-ESC4 & Find-ESC5 #136

Merged
merged 14 commits into from
Jul 16, 2024

Conversation

TrimarcJake
Copy link
Owner

This PR resolves #133 by changing the checked attribute from $entry.ActiveDirectoryRights.ObjectType to $entry.ObjectType

Also updated the Mandatory parameters for Find-ESC4 and Find-ESC5.

Copy link

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 16 1.91s
⚠️ EDITORCONFIG editorconfig-checker 15 1 0.15s
⚠️ MARKDOWN markdownlint 5 15 1.75s
⚠️ MARKDOWN markdown-link-check 5 8 2.57s
✅ MARKDOWN markdown-table-formatter 5 0 0.27s
⚠️ POWERSHELL powershell 10 7 14.78s
✅ POWERSHELL powershell_formatter 10 0 9.97s
⚠️ REPOSITORY checkov yes 1 13.61s
✅ REPOSITORY gitleaks yes no 0.43s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 17.9s
✅ REPOSITORY secretlint yes no 0.85s
✅ REPOSITORY trivy yes no 5.25s
✅ REPOSITORY trivy-sbom yes no 1.96s
✅ REPOSITORY trufflehog yes no 8.34s
⚠️ SPELL cspell 16 173 6.76s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@SamErde SamErde merged commit a35474e into testing Jul 16, 2024
3 checks passed
@TrimarcJake TrimarcJake deleted the 133-fix-false-positives branch July 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants