Fix ESC8 False Negatives #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Jake/Locksmith into fix-esc8-false-negatives
SamErde
reviewed
Aug 21, 2024
| $SID = $Principal | ||
| } else { | ||
| $SID = ($Principal.Translate([System.Security.Principal.SecurityIdentifier])).Value | ||
| if ($_.Name -ne '' -and $null -ne $_.Name) { |
There was a problem hiding this comment.
Wonder if this would work?
if (-not [string]::IsNullOrEmpty($_.Name)) { }
SamErde
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #153 by replacing attribute-based ESC8 checks with web request-based checks to validate the endpoint is online.
Also improved the
Fixattribute from[TODO]to something actually meaningful.Tested in 5 labs and 2 production environments so far. All 7 environments return the same results except @techspence 's lab