Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ESC3 Condition 2 detections #162

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Conversation

TrimarcJake
Copy link
Owner

The msPKI-Certiticate-Name-Flag isn't important for this check and was causing false negatives. FIXED!

Copy link

github-actions bot commented Sep 1, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 16 2.26s
⚠️ EDITORCONFIG editorconfig-checker 9 1 0.19s
⚠️ POWERSHELL powershell 9 8 19.67s
✅ POWERSHELL powershell_formatter 9 0 12.47s
⚠️ REPOSITORY checkov yes 1 11.62s
✅ REPOSITORY gitleaks yes no 0.61s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 16.12s
✅ REPOSITORY secretlint yes no 0.94s
✅ REPOSITORY trivy yes no 5.72s
✅ REPOSITORY trivy-sbom yes no 2.67s
✅ REPOSITORY trufflehog yes no 7.96s
⚠️ SPELL cspell 10 215 10.81s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Collaborator

@SamErde SamErde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm just curious, though: why did you change -eq to -match here?

@TrimarcJake
Copy link
Owner Author

Looks good. I'm just curious, though: why did you change -eq to -match here?

msPKI-RA-Application-Policies is a multi-value attribute, so -eq could create false negatives in the case where multiple Application Policies are specified.

It should technically be -match '1\.\3\.\6\.\1\.\4\.\1\.311\.20\.2\.1', I guess.

@SamErde SamErde merged commit 2e7cfb5 into testing Sep 1, 2024
3 checks passed
@TrimarcJake TrimarcJake deleted the improve-esc3c2-detections branch October 22, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants