Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates our testing to include PHP 8.3 and Drupal 10.2 #71

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

laceysanderson
Copy link
Member

Issue #70

Motivation

There was just a PR merged in core that updates Tripal core to support PHP 8.3 and Drupal 10.2. Obviously we want to test on these versions as well to confirm our support. This PR does that :-)

What does this PR do?

Please describe each things this PR does. For example, a PR may 1) solve a specific bug, 2) create an automated test to ensure it doesn't return.

  1. Updates the existing testing workflows to include PHP 8.3 and Drupal 10.2
  2. Updates workflows to use checkout action v4 to remove nodejs version warning
  3. Updates workflows to use test-tripal-action v1.3 so that we can have better control over versions of php used.
  4. Expands the testing grid in the readme to include the new version combinations.
  5. Makes the dockerfile default to php 8.3 and Drupal 10.2 since these are the versions we should be targeting now.
  6. Drupal 10.2 added a new permission to access help pages and became more stringent on permissions for pages. We made fixes to our existing tests with this in mind.

Testing

  1. Make sure the automated testing passes on all versions.
  2. Build the docker image both with and without phpversion build-args to ensure it pulls the correct tripal docker file.

@laceysanderson laceysanderson added the Group 5 | Automated Testing | Performance Any issue related to automated testing and improving performance label Feb 9, 2024
@laceysanderson laceysanderson self-assigned this Feb 9, 2024
@laceysanderson laceysanderson linked an issue Feb 9, 2024 that may be closed by this pull request
@reynoldtan
Copy link
Contributor

Confirmed resolved.
I was able to build a local docker without any errors.

I Noticed that the sub-menu is now on the left hand side (all the time), but this is unrelated and is about Drupal.

@laceysanderson laceysanderson merged commit 7626502 into 4.x Feb 9, 2024
8 checks passed
@laceysanderson laceysanderson deleted the g5.70-updateExistingTests branch February 9, 2024 16:54
@reynoldtan
Copy link
Contributor

Silly me, this little button puts it back beneath top navigation
Screen Shot 2024-02-09 at 10 58 38 AM 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group 5 | Automated Testing | Performance Any issue related to automated testing and improving performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants