MANTA-4932 rebalancer should not start jobs if snaplinks are enabled #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhb2
previously approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Still wrapping my head around the entirety of this change. Looks pretty good. I had some questions mostly. Also, if I'm understanding it correctly, it looks like most of this is really about being able to reload config information in a running process whenever changes are received. The actual code to address MANTA-4932 is relatively small. Is that right?
rjloura
force-pushed
the
MANTA-4932_snaplinks
branch
from
1dbae13 to
4243943
Compare
rjloura
commented
Mar 9, 2020
Comment on lines
+208
to
+218
|
|
||
| trace!("Got picker response: {:#?}", response); | ||
|
|
||
| // Storinfo, or our connection to it, is sick. So instead of | ||
| // breaking out of the loop and possibly returning partial results we | ||
| // return an empty Vec. | ||
| if response.status() != StatusCode::OK { | ||
| error!("Could not contact storinfo service {:#?}", response); | ||
| return vec![]; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the part that was added for "MANTA-4961 rebalancer job should not start if storinfo is unavailable"
rhb2
previously approved these changes
Mar 9, 2020
rhb2
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still have some testing to do but I wanted to get this posted so people can start to familiarize themselves with the change.