Resolve NodeJS v4.x build issue #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has an emit method, so use it instead of EventEmitter.prototype.emit
|
@sempasha are u using this in production? I consider branching of and using your code |
|
@mcavage Could you please consider merging this? |
|
+1 |
|
@cainvommars yes, I'm using this in production. |
|
@sempasha I forked your repo. Using it in production too. Thank you so much mate! |
|
+1 |
mcavage
pushed a commit
that referenced
this pull request
Nov 10, 2015
Resolve NodeJS v4.x build issue
|
@mcavage do not forget to bump package version, due to its incompatible with node v0.x since merge. Or I'm wrong maybe. |
|
@mcavage yes, please bump the major npm version. Otherwise, the things might not go well for many people who did not upgrade to node v4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue #27 and #26 (also see nodejs/node#2798)
Thanks to @rvagg for posting nodejs/nan#376 (comment)