node-sshpk#27 PuTTY private key support #76
Conversation
|
All done. |
|
@arekinath If you can, I'd like you to take another look at this before I merge it. |
bahamat
changed the title
|
Updated PR subject to link with issue #27 |
| lines.slice(si, si + privateLines).join(''), 'base64'); | ||
|
|
||
| if (encryption !== 'none' && formatVersion === 3) { | ||
| throw new Error('Encrypted keys arenot supported for PuTTY format version 3'); |
There was a problem hiding this comment.
Lines should be <80 chars
Use:
throw new Error('Encrypted keys arenot supported for' +
' PuTTY format version 3');
| if (parts) { | ||
| formatVersion = { | ||
| 'putty-user-key-file-2': 2, | ||
| 'putty-user-key-file-3': 3, |
There was a problem hiding this comment.
Line 30 should not have a , at the end.
Line 31 needs ; at the end.
|
Hi guys, straight up and honest, no offence, I'll keep working on encrypted PPK v3 support in my fork, but your crazy linting rules make fiddling with formatting just not worth my time, which is already stretched very thin. Feel free to tweak it if you want. |
|
@Eugeny No worries! I'll fix it up on my side post-merge. Again, sorry this took so long to go through. I'm definitely interested in the additional work you're doing for encrypted key support. When you have that ready I'll do what I can to fast-track it. And again, I'll deal with listing issues on my side. |
Adds support for PPKv2 format with DSA, RSA, ECDSA and Ed25519 keys