Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make site behave like single page application #155

Closed
PhilippSalvisberg opened this issue Aug 13, 2022 · 0 comments · Fixed by #156
Closed

Make site behave like single page application #155

PhilippSalvisberg opened this issue Aug 13, 2022 · 0 comments · Fixed by #156
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@PhilippSalvisberg
Copy link
Collaborator

PhilippSalvisberg commented Aug 13, 2022

You can navigate to the next and previous page by pressing the keys n and p. However, this leads to a reload of the page and the site feels sluggish. The user can see how the version selector drop down list is included into the page after the page load.

Materials for Mkdocs supports

These features should be enabled to improve the end user experience.

The custom JavaScript that produces the version drop down list is not required anymore.

The new drop down list will be shown on the title bar, after the title and the version number. This is redundant. Therefore I suggest to do not display the version number in the title anymore. The version selector is good enough in most cases. In cases such as "main" the version number is not visible. But that should be acceptable. This does not have an impact on the version number displayed in the PDF. It's still available there.

@PhilippSalvisberg PhilippSalvisberg self-assigned this Aug 13, 2022
@PhilippSalvisberg PhilippSalvisberg added this to the v4.2 milestone Aug 13, 2022
PhilippSalvisberg added a commit to PhilippSalvisberg/plsql-and-sql-coding-guidelines that referenced this issue Aug 13, 2022
PhilippSalvisberg added a commit to PhilippSalvisberg/plsql-and-sql-coding-guidelines that referenced this issue Aug 14, 2022
@PhilippSalvisberg PhilippSalvisberg added the enhancement New feature or request label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant